Always wrap long text in table display#19
Open
doiken wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
There are cases where long text breaks the table layout when displayed.
Below is a reproduction example:
Original data
Screenshot in Slack
This issue is due to the table-layout module's options configuration.
ref. https://github.com/75lb/table-layout/blob/v4.1.1/docs/API.md
Since no options are currently specified, maxWidth defaults to 80 characters.
Line breaks are only added when spaces or hyphens are present,
leading to the Slack output shown above.
This PR aims to improve table readability by adding the break option.
Testing:
Note:
We considered making the character limit per line configurable,
but Markdown formatting makes long lines difficult to read.
For this PR, we focused on the core implementation and opted against parameterizing this.